Add QEMU Guest Agent support for Windows provisioning#460
Open
mihaelabalutoiu wants to merge 3 commits into
Open
Add QEMU Guest Agent support for Windows provisioning#460mihaelabalutoiu wants to merge 3 commits into
mihaelabalutoiu wants to merge 3 commits into
Conversation
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
move_qemu_ga_core
branch
from
d441b42 to
7f77398
Compare
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
move_qemu_ga_core
branch
from
7f77398 to
8ef01ae
Compare
petrutlucian94
left a comment
petrutlucian94
left a comment
Member
There was a problem hiding this comment.
Looks good overall, just a few nits.
|
|
||
| virtio_iso_path = "c:\\virtio-win.iso" | ||
| virtio_iso_url = self._osmorphing_parameters["windows_virtio_iso_url"] | ||
| virtio_iso_path = VIRTIO_WIN_ISO_PATH |
Member
There was a problem hiding this comment.
nit: let's just use VIRTIO_WIN_ISO_PATH, no need for another variable.
|
|
||
| def _setup_qemu_agent_installation_local_script( | ||
| self, msi_source_path=None, msi_url=None, | ||
| msi_name="qemu-ga-x86_64.msi", qemu_ga_source_dir=None): |
Member
There was a problem hiding this comment.
nit: do we really need a parameter for the msi name? I'd just use "qemu-ga.msi" all the time. We may eventually support other platforms, e.g. arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
windows_virtio_iso_urlOSMorphing parameter;_install_dism_drivers helper;